fix(helpers): only deep merge plain objects #20284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The defaults composable uses the
mergeDeep
helper to merge defaults. However, it is not able to merge properties with HTML elements, like for example, theattach
property of all overlays, because it throws a maximum call stack size exceeded.Changed the
mergeDeep
utility to handle objects with circular references and to avoid traversing Nodes. Also added two new tests to check these changes.fixes #20278
Markup: